[receiver/hostmetrics] Fix processscraper resource attribute test #36526
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, this test was repeatedly testing the first process in the resource. This tended to just work, but is not testing what it is supposed to. When changing it to test every resource in the scrape, it came up with issues due to the fact that not all resource attributes can always be found. This PR changes the test to look at all process resources in the scrape, and instead of asserting the presence of every resource attribute, it checks for one mandatory attribute (the process ID) and ensures that no unexpected resource attributes are added. This should reduce the flakiness of this test on other environments, while still asserting this on every process resource in the list.
|
I would like to |
|
/label skip-changelog |
|
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
|
Triage: Adding |
|
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
|
This is still relevant, unstale |
dmitryax
approved these changes
Jan 6, 2025
AkhigbeEromo
pushed a commit
to sematext/opentelemetry-collector-contrib
that referenced
this pull request
Jan 13, 2025
…en-telemetry#36526) #### Description Previously, this test was repeatedly testing the first process resource in the list. This would usually pass (on non-Mac machines), but is not testing what it is supposed to. When changing it to test every resource in the scrape, it came up with issues due to the fact that not all resource attributes can always be found for every process. This PR changes the test to look at all process resources in the scrape, and instead of asserting the presence of every resource attribute, it checks for one mandatory attribute (the process ID) and ensures that no unexpected resource attributes are added. This should reduce the flakiness of this test on other environments, while still asserting this on every process resource in the list. #### Link to tracking issue Fixes open-telemetry#36468 #### Documentation A comment was added to the assertion helper, and more detailed error messages are produced on failure.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Previously, this test was repeatedly testing the first process resource in the list. This would usually pass (on non-Mac machines), but is not testing what it is supposed to. When changing it to test every resource in the scrape, it came up with issues due to the fact that not all resource attributes can always be found for every process.
This PR changes the test to look at all process resources in the scrape, and instead of asserting the presence of every resource attribute, it checks for one mandatory attribute (the process ID) and ensures that no unexpected resource attributes are added. This should reduce the flakiness of this test on other environments, while still asserting this on every process resource in the list.
Link to tracking issue
Fixes #36468
Testing
Running the tests.
Documentation
A comment was added to the assertion helper, and more detailed error messages are produced on failure.